🐛 Add more exceptions to namer

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers

Apache License 2.0

4 stars 11 forks source link

🐛 Add more exceptions to namer #91

Closed embik closed 5 months ago

embik commented 5 months ago

Summary

As part of https://github.com/kcp-dev/client-go/pull/37 I realised we have two new types in k8s.io (going from 1.28 to 1.30) that don't work with the current name generator. We should probably look at re-adopting upstream functionality here, but for now these two new exceptions will work.

Related issue(s)

Fixes #

Release Notes

Add naming exceptions for `ResourceClaimParameters` and `ResourceClassParameters`

mjudeikis commented 5 months ago

/lgtm /approve

kcp-ci-bot commented 5 months ago

LGTM label has been added.

Git tree hash: 9f0021f4dcff42f165910fc8d4a5419ea376a135

kcp-ci-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment