search

kcp-dev / code-generator

Generators for workspace-aware clientsets, informers, and listers
Apache License 2.0
4 stars 11 forks source link

:sparkles: k/k 1.31.0 rebase #92

Closed mjudeikis closed 1 month ago

mjudeikis commented 2 months ago

Summary

Rebase to 1.31.

Changes:

  1. Update all external generators to match future versions of kcp
  2. regression (our side kind of) fix for genclient:skipVerbs=list,watch. If skipped, on our end we skip List, Watch and DeleteCollections. It should be just List and Watch. Need to fix this or redo our generators
  3. Make definition def.Strict = false as we (k/k) changed some tags where now they are group=, meaning its not full key-value-pair. This passes the validation as its non-strict mode. This could have consequences that we miss some API groups in the future.

In general, we should see how to make these generators closer to upstream v2 as now they are bespoke solutions. Or live with a bespoke solution. I would better invest time in refactoring them while we have time, and it's not a hard blocker for rebase.

Related issue(s)

Fixes #

Release Notes

1.31 rebase 
Make generator stricts=false
kcp-ci-bot commented 1 month ago

LGTM label has been added.

Git tree hash: fc304296f4af40b279cb31aec95cf54cddf06ee2

kcp-ci-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/code-generator/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment