search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 21 forks source link

Remove the extraFlags kcp chart parameter #16

Closed kylape closed 1 week ago

kylape commented 2 years ago

This was just a hack to address some backwards-incompatible flag changes in kcp. In the future kcp releases should be better coordinated with the helm chart releases.

xrstf commented 10 months ago

@mjudeikis @embik WDYT about this? Leave extraFlags to make customizations possible, or remove it to prevent users from fiddling with the flags?

mjudeikis commented 5 months ago

I dont think we have way to provide feature-gates now:

  extraFlags:
  - --feature-gates=WorkspaceMounts=true

So we need it until we get it into charts too

mjudeikis commented 5 months ago

So to remove this we need add ability to provide featuregates list first

kcp-ci-bot commented 2 months ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kcp-ci-bot commented 1 month ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kcp-ci-bot commented 1 week ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kcp-ci-bot commented 1 week ago

@kcp-ci-bot: Closing this issue.

In response to [this](https://github.com/kcp-dev/helm-charts/issues/16#issuecomment-2313467298): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.