search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 21 forks source link

Extra configuration #2

Closed jimmidyson closed 2 years ago

jimmidyson commented 2 years ago

A number of changes to use kcp helm chart with an external etcd (to make maintenance easier when this is eventually ready for production), as well as removing configuration specific to the red hat environment. This PR also adds configuration to work with vanilla kubernetes via changes such as adding Ingress and Gateway configuration in addition to OpenShift Routes.

kylape commented 2 years ago

Hey, thanks for all these changes! I'll try to get them reviewed in the next day or so.

jimmidyson commented 2 years ago

Thanks @kylape! These changes mean that you would need to provide some values to deploy on OpenShift but I personally think that targeting vanilla Kubernetes is better for wider adoption.

kylape commented 2 years ago

Oh absolutely. I just dumped what I had configured for our Openshift-specific setup, so making things more generic is excellent.