kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 21 forks source link

Auth token support + kind cluster helper #27

Closed mjudeikis closed 1 year ago

mjudeikis commented 1 year ago

In this PR:

  1. Rename readme.md to README.md (sorry, nitpicking)
  2. Add the ability to deploy with a token file
  3. Remove lets encrypt production issuer as default (does not work well with kind)
  4. Add helper script to deploy end-to-end kind cluster with self-signed certificates and localhost ingress (nginx)
mjudeikis commented 1 year ago

happy to "downsize" this PR if people think this is too much :)

hardys commented 1 year ago

happy to "downsize" this PR if people think this is too much :)

Personally I think it's OK as one PR, but it would be nice to break it into a few commits if possible since it's not all strictly related to the kind helper script.

mjudeikis commented 1 year ago

@hardys is there anything else you want me to change on this?

mjudeikis commented 1 year ago

@hardys whats missing to merge this?

xrstf commented 1 year ago

Closing to re-open again, just to get Prow working. Please do not be alarmed.

mjudeikis commented 1 year ago

/approved /lgtm

kcp-ci-bot commented 1 year ago

@mjudeikis: you cannot LGTM your own PR.

In response to [this](https://github.com/kcp-dev/helm-charts/pull/27#issuecomment-1602094617): >/approved >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment