search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 21 forks source link

Standardize resource configuration #40

Closed embik closed 1 year ago

embik commented 1 year ago

I've never seen the way that the kcp Helm chart configures resources. This updates values.yaml and affected templates to use a de-facto standard for Helm charts, used in popular Helm charts like cert-manager or ingress-nginx.

embik commented 1 year ago

/cc @mjudeikis

mjudeikis commented 1 year ago

front-proxy currently has hardcoded resource limits. worth changing as we going with it?

embik commented 1 year ago

front-proxy currently has hardcoded resource limits. worth changing as we going with it?

Yes, absolutely. let me take care of it.

embik commented 1 year ago

@mjudeikis done, PTAL again!

mjudeikis commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: a95d9f70982e750b711875946e3da35fd323432c