search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

set HTTPS backend annotation on Ingress resource by default #43

Closed embik closed 1 year ago

embik commented 1 year ago

Because the kcp-front-proxy serves HTTPS by default, installing the chart without customizing the Ingress annotations will result in an error looking like

Client sent an HTTP request to an HTTPS server.

While this setting depends on the ingress controller in use, we already set kubernetes.io/ingress.class=nginx, so the general expectation of the default Helm values is that nginx-ingress-controller is deployed. Adding this annotation to the default set makes that implicit reference setup fully work.

In addition, this PR adds a comment so that users of other ingress controllers can look up what their implementation requires for similar functionality.

embik commented 1 year ago

/cc @mjudeikis

mjudeikis commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 6f0c7dc9e24de4c0daf9b512d8966c32187f384d

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment