search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

wrap oidc prefix flag values into single quotes #44

Closed embik closed 1 year ago

embik commented 1 year ago

This is a fix for when the oidc username group prefixes values include a trailing colon. Helm really does not like that for some reason (or is it Kubernetes in the first place?), so this PR wraps the two values into single quotes to make it clear the colon is no part of YAML structure.

Example values that caused this problem:

oidc:
  usernamePrefix: 'oidc:'
  groupsPrefix: 'oidc:'
embik commented 1 year ago

/cc @mjudeikis

embik commented 1 year ago

Never mind, kcp actually picks this up and makes 'oidc:'marvin@kubermatic.com out of it.

/hold

embik commented 1 year ago

/hold cancel

now it works.

mjudeikis commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 14a9145a77de0c7241833ee72a9073df3f4f4c07