🐛 wrap EXTERNAL_PORT to make sure it's seen as string

kcp-dev / helm-charts

Helm chart repo for KCP

Apache License 2.0

4 stars 18 forks source link

🐛 wrap EXTERNAL_PORT to make sure it's seen as string #46

Closed embik closed 1 year ago

embik commented 1 year ago

I keep forgetting that YAML does this - this fixes an issue I added in #45.

This produces failed upgrades with errors like this:

 json: cannot unmarshal number into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

In addition, I committed the type: LoadBalancer change that was only meant for local testing. My bad, fixing this as well.

embik commented 1 year ago

/cc @mjudeikis

embik commented 1 year ago

/hold

embik commented 1 year ago

/hold cancel

mjudeikis commented 1 year ago

/approve /lgtm

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: ce6ee4d6d5e53c31901a718573c2c9215017f424