search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 22 forks source link

change port in external-logical-cluster-admin kubeconfig when exposing front proxy directly #48

Closed embik closed 1 year ago

embik commented 1 year ago

When exporting the front proxy directly via a LoadBalancer service, this kubeconfig needs to be updated to use the correct external port. This matches the EXTERNAL_PORT environment variable set in the kcp Deployment, but we cannot read from it here, so we need to replicate the logic.

embik commented 1 year ago

/cc @mjudeikis

mjudeikis commented 1 year ago

/approve /lgtm

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 25ffa7a888ade28b87e395e8f7bb65f286b1afb7

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment