Closed MikeSpreitzer closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: embik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM label has been added.
Without this PR, setting
etcd.enabled
tofalse
andkcp.etcd.serverAddress
toembedded
is not enough because it leaves the kcp server hanging due to the absence of the Secret namedkcp-etcd-client
, which is absent because the corresponding Certificate never gets that Secret issued, because it is asking for an issuer that does not exist due to theetcd.enabled = false
setting.This PR makes the dependence on the Secret named
kcp-etcd-client
go away ifkcp.etcd.serverAddress
is set toembedded
, and adds the Certificate namedkcp-etcd-client
to the stuff that goes away ifetcd.enabled
is set tofalse
.Successfully tested with
etcd.enabled = false
andkcp.etcd.serverAddress = "embedded"
.Should also be functional with
etcd.enabled = false
andkcp.etcd.serverAddress
set to some pre-existing etcd cluster and the Secret namedkcp-etcd-client
already existing and holding the TLS credentials needed to access that etcd cluster.