search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

Move security context to `values.yaml` #54

Closed embik closed 10 months ago

embik commented 10 months ago

Since the securityContext I added to make the Helm chart work on vanilla Kubernetes is creating issues on OpenShift, this moves configuration for it to values.yaml file so we ship a sane default for (vanilla) Kubernetes users while allowing others to override settings as they require.

This is related to #52.

embik commented 10 months ago

/cc @mjudeikis @MikeSpreitzer

mjudeikis commented 10 months ago

/lgtm /approve

kcp-ci-bot commented 10 months ago

LGTM label has been added.

Git tree hash: 4692aa4be4b3104c30f53746769b03880238a10b

kcp-ci-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment