Improve kind scripting - Githubissues

xrstf commented 10 months ago

This PR updates the kind-setup script:

re-indented the code
Use yq instead of cat|grep|cut|tr.
kind is only installed locally (no sudo required) and only if it's not existing (regardless of where the binary exists).
The kind cluster was updated to 1.27.3 (with this release, the EphemeralContainer feature gate became GA and was removed).
The script now provides a kcp.kubeconfig and a kcp-kind.kubeconfig.
kubectl rollout status is used instead of a custom wait loop that greps for numbers.
cert-manager was updated from 1.9.1 to 1.13.0.
At the moment, kcp does not produce latest images anymore, so the script now allows to set KCP_TAG to override the version and actually install something recent (e.g. KCP_TAG=bb5ce8f3 hack/kind-setup.sh).
The /etc/hosts adjustments now take the actual root domain into account, instead of hardcoding kcp.dev.local.

This might not work properly without #56, as I used #56 to test this PR.

mjudeikis commented 10 months ago

Nice :) waiting for this to get in ;D "bash'land magic"

xrstf commented 9 months ago

@mjudeikis PTAL when you have the time :)

kcp-ci-bot commented 9 months ago

LGTM label has been added.

Git tree hash: 3e3d6a38a5b72531074610671be76749f998d996

mjudeikis commented 9 months ago

/lgtm /approve

kcp-ci-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kcp-dev / helm-charts

Improve kind scripting #57