search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 21 forks source link

Add presubmit job to prevent chart from going bad #58

Closed xrstf closed 1 year ago

xrstf commented 1 year ago

My previous PR accidentally broke the chart because after rebasing I did not test it again.

This PR adds a presubmit job to prevent this from happening again.

kcp-ci-bot commented 1 year ago

@xrstf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-helm-charts-verify ae1343ca9c4d8155e8d4a094f7edb9b7205e341a link true /test pull-kcp-helm-charts-verify

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 9f38e95548410e123de8dad7a531661fc197d6fc