search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

Move resources into dedicated files with component prefixes #62

Closed embik closed 10 months ago

embik commented 10 months ago

This is a rather subjective PR, so I'm soliciting as much feedback as I can get.

When I work with the Helm chart, I find it rather difficult to find the correct file and instead mostly search for resource names. I would like templates to have some form of structure, so I've split the individual components' big YAML bundles into smaller files, while preserving their component association by prefixing the files with them.

I think this is cleaner and helps in maintaining the chart, but I'm not hellbent on getting this change in if there's no agreement on this being "cleaner" in the first place.

embik commented 10 months ago

/cc @mjudeikis

embik commented 10 months ago

/cc @xrstf

xrstf commented 10 months ago

/lgtm

kcp-ci-bot commented 10 months ago

LGTM label has been added.

Git tree hash: 22d4f8f99c7a3bbc19d7183e848417445d56f500

embik commented 10 months ago

/approve

kcp-ci-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment