search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

🐛 Wrong image tag #70

Closed francostellari closed 7 months ago

francostellari commented 8 months ago

The helm chart seems to default to an image tag that does not exists:

$ helm install kcp kcp/kcp --version 0.4.0 --set externalHostname=my-dns --debug --dry-run | grep "image: ghcr.io/kcp-dev/kcp"
install.go:200: [debug] Original chart version: "0.4.0"
install.go:217: [debug] CHART PATH: /home/vagrant/.cache/helm/repository/kcp-0.4.0.tgz

  image: ghcr.io/kcp-dev/kcp
  image: ghcr.io/kcp-dev/kcp
          image: ghcr.io/kcp-dev/kcp:v0.21.0

Yet:

$ docker pull ghcr.io/kcp-dev/kcp:v0.21.0
Error response from daemon: manifest unknown

Looking at ghcr.io/kcp-dev/kcp I see a main, 'latest, release-0.21 tags

Which one should I use?

francostellari commented 8 months ago

cc @MikeSpreitzer @clubanderson

francostellari commented 8 months ago

Here are the default images for previous versions of the chart:

$ helm install kcp kcp/kcp --version 0.3.0 --set externalHostname=my-dns --debug --dry-run | grep "image: ghcr.io/kcp-dev/kcp"
install.go:200: [debug] Original chart version: "0.3.0"
install.go:217: [debug] CHART PATH: /home/vagrant/.cache/helm/repository/kcp-0.3.0.tgz

  image: ghcr.io/kcp-dev/kcp
  image: ghcr.io/kcp-dev/kcp
        image: ghcr.io/kcp-dev/kcp:latest
        image: ghcr.io/kcp-dev/kcp:latest
$ helm install kcp kcp/kcp --version 0.2.5 --set externalHostname=my-dns --debug --dry-run | grep "image: ghcr.io/kcp-dev/kcp"
install.go:200: [debug] Original chart version: "0.2.5"
install.go:217: [debug] CHART PATH: /home/vagrant/.cache/helm/repository/kcp-0.2.5.tgz

  image: ghcr.io/kcp-dev/kcp
  image: ghcr.io/kcp-dev/kcp
        image: ghcr.io/kcp-dev/kcp:latest
        image: ghcr.io/kcp-dev/kcp:latest
embik commented 8 months ago

It looks like the v0.21.0 image didn't build. Also tracking at https://github.com/kcp-dev/kcp/issues/3043

embik commented 7 months ago

Tag is now available, it is no longer necessary to override the image tag with release-0.21 (see linked kcp issue above).