search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 22 forks source link

📖 use correct issuer for client certificates in README.md #71

Closed embik closed 1 year ago

embik commented 1 year ago

Looks like we were still referencing the issuer for client certificates for the kcp server. But we fixed CAs a while ago, so the client certificate should be issued by the dedicated kcp-front-proxy-client-issuer.

ref on #kcp-dev

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 83439e61ac3e8619f6f7b583b8bc3942a7924866

embik commented 1 year ago

/approve

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment