search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 21 forks source link

✨ Add `kcp.batteries` to `values.yaml` and set them on kcp deployment #73

Closed embik closed 10 months ago

embik commented 10 months ago

Fixes #69.

This adds kcp.batteries to the chart's values.yaml and sets the --batteries-included flag on the kcp Deployment.

This will become useful with a future release of kcp that includes https://github.com/kcp-dev/kcp/pull/3041 (the admin battery) so we can disable writing admin.kubeconfig.

kcp-ci-bot commented 10 months ago

LGTM label has been added.

Git tree hash: 4073f91cb8e19e12df04a6732d456531000c3262

embik commented 10 months ago

/approve

kcp-ci-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment