search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 22 forks source link

⚠️ correctly check if etcd StatefulSet is enabled to set `--etcd-servers` #74

Closed embik closed 1 year ago

embik commented 1 year ago

All the time back in #65, I made a mistake in the if condition guarding the --etcd-servers flag. .kcp.etcd.enabled doesn't exist, etcd.enabled does. This fixes that oversight. Because the flag wasn't set, kcp was using the embedded etcd.

⚠️ This is a breaking change because it will change the kcp server from using the embedded etcd as datastore to the external etcd StatefulSet that is part of the Helm chart. But this will seemingly wipe all data from your kcp instance.

If you want to retain data, you'll need to set .kcp.etcd.serverAddress="embedded" before upgrading.

mjudeikis commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 8c7bfa2036cadce82873a76bc8feb6dd469019c3

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment