Closed embik closed 5 months ago
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mjudeikis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM label has been added.
This PR bumps the chart to use kcp v0.22.0, which felt like a minor version bump for the chart version, hence the bump to v0.5.0 as well.
In addition, this PR picks up on some goodies we added in the new kcp release:
admin.kubeconfig
and associated files is now hidden in theadmin
battery (which is not enabled in the batteries of this helm chart), we can replace the PVC with an emptyDir. Thekcp
binary still complains if/etc/kcp/config
does not exist, but it creates nothing in that directory. So I put a dummy volume with a size limit of 50Mi in there.