kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
4 stars 18 forks source link

✨ Add support for monitoring kcp with prometheus-operator #82

Closed embik closed 3 months ago

embik commented 5 months ago

This adds three ServiceMonitor objects that can be enabled to monitor the components deployed by the kcp Helm chart: etcd, kcp-front-proxy and kcp(-server).

mjudeikis commented 4 months ago

/approve /lgtm

kcp-ci-bot commented 4 months ago

LGTM label has been added.

Git tree hash: 96d4a04e543ca513d2796e035c6a705b89c9abd2

kcp-ci-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mjudeikis commented 4 months ago

@embik whats holding this up?

embik commented 4 months ago

@embik whats holding this up?

Now that 0.23.0 is out with metrics-viewer battery fix: Days just having 24 hours.

I'll get back to finalizing this as soon as possible.

embik commented 3 months ago

/hold cancel

embik commented 3 months ago

/cc @mjudeikis

xrstf commented 3 months ago

/lgtm

kcp-ci-bot commented 3 months ago

LGTM label has been added.

Git tree hash: a78208e6856d7aa9b21982cb6b40d9a442115726