:sparkles: Nit fixes for sharded example

kcp-dev / helm-charts

Helm chart repo for KCP

Apache License 2.0

5 stars 22 forks source link

:sparkles: Nit fixes for sharded example #87

Closed mjudeikis closed 8 months ago

mjudeikis commented 8 months ago

Fixes sharded example a bit This proves it works in tilt PR (depends on this one) https://github.com/kcp-dev/kcp/pull/3037

mjudeikis commented 8 months ago

After this I have nice tilt with sharding and IDP working :)

sttts commented 8 months ago

/lgtm /approve

kcp-ci-bot commented 8 months ago

LGTM label has been added.

Git tree hash: 5b4eb1e7666465989377860337fd66b7243461f8

kcp-ci-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment