Newer versions of etcd uses distroless, i.e. /bin/sh is not available for etcd shard

kcp-dev / helm-charts

Helm chart repo for KCP

Apache License 2.0

5 stars 21 forks source link

Newer versions of etcd uses distroless, i.e. /bin/sh is not available for etcd shard #94

Closed luxas closed 1 month ago

luxas commented 1 month ago

etcd 3.5.7 moved to use a distroless base image, so /bin/sh cannot be used anymore here: https://github.com/kcp-dev/helm-charts/blob/a8454bb85f19da71bfb9074d54deff5bb600aa68/charts/shard/templates/etcd-statefulset.yaml#L45

Could we convert the PEERS environment variable to be set by the PodSpec instead of within the arguments; and execute etcd binary directly perhaps?

embik commented 1 month ago

Hey @luxas, I also brought this up in #72. We'd absolutely be open to converting things so they work without /bin/sh, none of the maintainer got to it yet though. Contributions would be welcome, but I can also try to pick this up if that's not an option.

luxas commented 1 month ago

Sorry, didn't realize #72 was the same issue, I'll close this and move to #72. Thanks!

embik commented 1 month ago

No worries at all!