search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 21 forks source link

Don't make use of /bin/sh in etcd images & update etcd version #95

Closed luxas closed 1 month ago

luxas commented 1 month ago

Fixes: #72

@mjudeikis do you want me to update the default etcd Helm value as well? I verified the CLI flags to etcd stayed the same before and after, and that a StatefulSet upgrade to etcd version v3.5.15 in Helm values worked 👍

cc @sttts

kcp-ci-bot commented 1 month ago

Hi @luxas. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mjudeikis commented 1 month ago

do you want me to update the default etcd Helm value as well? You mean version of etcd? If so - just bump them too.

luxas commented 1 month ago

ok, I'll bump the default etcd version to 3.5.15 then 👍

mjudeikis commented 1 month ago

/lgtm /approve

kcp-ci-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 month ago

LGTM label has been added.

Git tree hash: a0d76b5fafedb14fa88ec3f8ccc0e47d35ab9faf