kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 21 forks source link

fix front-proxy Ingress' backend service #97

Closed ErwanDL closed 2 weeks ago

ErwanDL commented 2 weeks ago

I believe the backend.service.name targeted by the Ingress for the front-proxy should use the front-proxy's templated name, instead of having "kcp-front-proxy" hardcoded.

kcp-ci-bot commented 2 weeks ago

Hi @ErwanDL. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
embik commented 2 weeks ago

Hi @ErwanDL, thank you for the contribution! For us being able to accept it, all commits need to be signed off on (git commit --signoff) so that you confirm that you are contributing under the DCO. Please update your commits, then we'll be able to accept your fix (many thanks for catching this!)

embik commented 2 weeks ago

/ok-to-test

kcp-ci-bot commented 2 weeks ago

LGTM label has been added.

Git tree hash: 7749b48281f1946efae539db20c61271584b3564

kcp-ci-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ErwanDL commented 2 weeks ago

Thank you!