Closed ErwanDL closed 3 months ago
Hi @ErwanDL. Thanks for your PR.
I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Hi @ErwanDL, thank you for the contribution! For us being able to accept it, all commits need to be signed off on (git commit --signoff
) so that you confirm that you are contributing under the DCO. Please update your commits, then we'll be able to accept your fix (many thanks for catching this!)
/ok-to-test
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: embik
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you!
I believe the
backend.service.name
targeted by the Ingress for the front-proxy should use the front-proxy's templated name, instead of having "kcp-front-proxy" hardcoded.