kcp-ci-bot
commented
2 weeks ago [APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from embik. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
- **[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)**
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
Support for running with embedded etcd (a mode implemented in kcp for local development) has been added in #51. Unfortunately, it has been broken since #81 when I started eliminating the use of kcp's root directory for anything. A follow-up to that is currently in review at https://github.com/kcp-dev/kcp/pull/3158.
As per the thread on Slack, it seems we are in agreement that this shouldn't be supported anymore. It seems that no adopter is actually using it (since it's broken since beginning of the year) and it creates severe headache to running kcp as a Deployment.