search

kcp-dev / helm-charts

Helm chart repo for KCP
Apache License 2.0
5 stars 22 forks source link

Remove support for embedded etcd in Chart #99

Closed embik closed 2 months ago

embik commented 3 months ago

Support for running with embedded etcd (a mode implemented in kcp for local development) has been added in #51. Unfortunately, it has been broken since #81 when I started eliminating the use of kcp's root directory for anything. A follow-up to that is currently in review at https://github.com/kcp-dev/kcp/pull/3158.

As per the thread on Slack, it seems we are in agreement that this shouldn't be supported anymore. It seems that no adopter is actually using it (since it's broken since beginning of the year) and it creates severe headache to running kcp as a Deployment.

sttts commented 2 months ago

/lgtm /approve

kcp-ci-bot commented 2 months ago

LGTM label has been added.

Git tree hash: cf66c485ba9f6c9050ef04945399bbabb4850cf1

kcp-ci-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/helm-charts/blob/main/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment