search

kcp-dev / infra

CI infrastructure
Apache License 2.0
6 stars 11 forks source link

prow/jobs/infra: fix label-sync jobs #23

Closed nikhita closed 1 year ago

nikhita commented 1 year ago

The label-config configmap is in the prow namespace and the prowjob runs in the default namespace.

Let's avoid using a configmap altogether and derive labels.yaml from the cloned infra repo.

kcp-ci-bot commented 1 year ago

Hi @nikhita. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xrstf commented 1 year ago

/ok-to-test /lgtm /approve

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 4dfb04105ae91e56ee87e41242b676387348b607

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/infra/blob/main/OWNERS)~~ [xrstf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

@nikhita: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/kcp-dev/infra/pull/23): >The `label-config` configmap is in the prow namespace and the prowjob runs in the default namespace. > >Let's avoid using a configmap altogether and derive `labels.yaml` from the cloned infra repo. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.