Closed embik closed 1 year ago
/cc @xrstf
Hi @embik. Thanks for your PR.
I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/approve /lgtm
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xrstf
The full list of commands accepted by this bot can be found here.
The pull request process is described here
So after debugging this for a long time, trying all sorts of things, it seems that there are just some bugs (?) in github (?) and/or prow (?) that prevent PRs from getting merged under certain conditions.
We are apparently not the first to experience this, as @nikhita found out on k8s slack:
It seems to be related to the fact that this PR modifies .github/
.
Hoping that the problem will not happen again with future PRs that only modify and not add new stuff to .github/
, let's merge this and :crossed_fingers:
This is the third time I'm trying to make Prow merge my PR (previously: #35 and #34).