search

kcp-dev / infra

CI infrastructure
Apache License 2.0
6 stars 11 forks source link

change owner file names for kcp-dev/controller-runtime #40

Closed xrstf closed 1 year ago

xrstf commented 1 year ago

This makes it so Prow ignores the upstream files (OWNERS) and instead uses our files, otherwise we could not approve our own PRs.

This mirrors https://github.com/openshift/release/blob/master/core-services/prow/02_config/_plugins.yaml#L2688

sttts commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: 56639b0f68eda2739c1ce9128437376473324dc0

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/infra/blob/main/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

@xrstf: Updated the plugins configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/kcp-dev/infra/pull/40): >This makes it so Prow ignores the upstream files (OWNERS) and instead uses our files, otherwise we could not approve our own PRs. > >This mirrors https://github.com/openshift/release/blob/master/core-services/prow/02_config/_plugins.yaml#L2688 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.