search

kcp-dev / infra

CI infrastructure
Apache License 2.0
6 stars 11 forks source link

add preset-ghcr-credentials Prow preset #45

Closed xrstf closed 1 year ago

xrstf commented 1 year ago

xref https://kubernetes.slack.com/archives/C021U8WSAFK/p1686089777445089

This provides a new preset for prowjobs to gain access to the GHCR. Prowjob will need to run in the somewhat protected prow cluster instead of the regular build cluster, as a little extra security. The credentials in this secret can only manage packages and nothing else.

sttts commented 1 year ago

/lgtm /approve

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/infra/blob/main/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: ef1078ac4e0313e84584d49609006099e278a981

kcp-ci-bot commented 1 year ago

@xrstf: Updated the config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/kcp-dev/infra/pull/45): >xref https://kubernetes.slack.com/archives/C021U8WSAFK/p1686089777445089 > >This provides a new preset for prowjobs to gain access to the GHCR. Prowjob will need to run in the somewhat protected prow cluster instead of the regular build cluster, as a little extra security. The credentials in this secret can _only_ manage packages and nothing else. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.