search

kcp-dev / infra

CI infrastructure
Apache License 2.0
6 stars 11 forks source link

🌱 Move builds for `ghcr.io/kcp-dev/infra/build` to prow #50

Closed embik closed 1 year ago

embik commented 1 year ago

Initially I added builds for ghcr.io/kcp-dev/infra/build in #35 via GitHub Actions because that was how kcp-dev/kcp was doing it. Now the core repository has migrated to building images in prow, so this PR adapts the changes made there (https://github.com/kcp-dev/kcp/pull/2976) into the infra repository for our build image as well.

I'm leaving the multi-arch aspect in because I find it useful, it's less divergence from the kcp script and it could unlock running jobs on ARM if we later chose so, by just dropping that architecture in the list for our build image.

embik commented 1 year ago

/cc @xrstf

xrstf commented 1 year ago

/approve /lgtm

kcp-ci-bot commented 1 year ago

LGTM label has been added.

Git tree hash: e1c808454abe6ccf71109b838354f26fe9abb796

kcp-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/infra/blob/main/OWNERS)~~ [xrstf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kcp-ci-bot commented 1 year ago

@embik: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/kcp-dev/infra/pull/50): >Initially I added builds for `ghcr.io/kcp-dev/infra/build` in #35 via GitHub Actions because that was how kcp-dev/kcp was doing it. Now the core repository has migrated to building images in prow, so this PR adapts the changes made there (https://github.com/kcp-dev/kcp/pull/2976) into the infra repository for our build image as well. > >I'm leaving the multi-arch aspect in because I find it useful, it's less divergence from the kcp script and it could unlock running jobs on ARM if we later chose so, by just dropping that architecture in the list for our build image. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.