kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.35k stars 381 forks source link

kubectl version produces an error #1419

Closed lionelvillard closed 2 years ago

lionelvillard commented 2 years ago

Describe the bug Running kubectl version against kcp produces an error:

WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:17:11Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+$Format:%H$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"darwin/amd64"}
error: could not parse pre-release/metadata (-master+$Format:%H$) in version "v0.0.0-master+$Format:%H$"

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

No error

Additional context Add any other context about the problem here.

branch: main

lionelvillard commented 2 years ago

It works when using make build.

Maybe the doc should be updated: https://github.com/kcp-dev/kcp#how-do-i-get-started. WDYT?

ncdc commented 2 years ago

We should do a doc update:

  1. Do make install instead of go run
  2. Make sure you PATH is correct