search

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.33k stars 378 forks source link

Adding readiness checkups in KCP #1526

Closed samyak-jn closed 3 months ago

samyak-jn commented 2 years ago

Is your feature request related to a problem? Please describe.

When deploying ArgoCD to KCP, one of the initial blocker we face is due to the readyz and health checkups by ArgoCD on the cluster, which as per my knowledge KCP still don't support. So while deploying the argocd, the argo looks for some health and readiness checks from the cluster, while doing so it looks for a port service for checking if the cluster is ready or not, which while doing so on KCP turns out to be the blocker, As stts mentioned readiness in the sense of kube-apiserver /readyz; basically to serve /clusters/root:org:ws/readyz

Describe the solution you'd like

Enable readiness and health probes checkup in KCP in each workspace, for ex: /clusters/root:org:ws/readyz so, in case I'm deploying argocd in org->A ws->test then, the readiness can be checked at /clusters/root:A:test/readyz

Describe alternatives you've considered For now, to make ArgoCD deploy on KCP, we have disabled those checks hence this feature request will unblock us form that.

CC: @sttts, in case I missed some details, feel free to chime in, thanks!

ncdc commented 2 years ago

Idea: redirect per cluster livez/readyz to the main paths (without /clusters/)

pradeepnnv commented 2 years ago

I would like to work on this please.

kcp-ci-bot commented 5 months ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kcp-ci-bot commented 4 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kcp-ci-bot commented 3 months ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kcp-ci-bot commented 3 months ago

@kcp-ci-bot: Closing this issue.

In response to [this](https://github.com/kcp-dev/kcp/issues/1526#issuecomment-2164995612): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.