Closed turkenh closed 1 month ago
Hi @turkenh. Thanks for your PR.
I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
With https://github.com/kcp-dev/kcp/pull/3156 the problem here goes away as the external virtual workspace user is preserved.
/lgtm /approve /ok-to-test
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sttts
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Summary
We have some validations on our CRDs where we would like to act based on the user information, i.e., we want to allow a specific field to only be initialized by a controller but no one else. The current implementation of build virtual workspaces loses the original user info while doing impersonation.
This PR adds original user and groups information to impersonating client as
extra
, so that our validator can extract the user/group information and make decisions accordingly.Related issue(s)
N/A
Release Notes