:bug: virtual/apiexport: don't keep recreating APIBindings storage

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.

https://kcp.io

Apache License 2.0

2.39k stars 383 forks source link

:bug: virtual/apiexport: don't keep recreating APIBindings storage #3168

Closed sttts closed 2 months ago

sttts commented 2 months ago

Summary

The fallback code to always serve APIBindings in the apiexport virtual workspace lacked logic to preserve the old storage. So on any other change or resync, the APIBinding storage was recretaed.

Related issue(s)

Fixes #

Release Notes

NONE

mjudeikis commented 2 months ago

/lgtm /approve

kcp-ci-bot commented 2 months ago

LGTM label has been added.

Git tree hash: 064187e9a27eb41efc29b32160d954f68d9fea0c

kcp-ci-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/kcp/blob/main/OWNERS)~~ [mjudeikis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment