search

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.39k stars 383 forks source link

:seedling: Fix bad smells #3176

Closed cupakob closed 1 month ago

cupakob commented 2 months ago

Summary

Related issue(s)

Fixes #

Release Notes

NONE
kcp-ci-bot commented 2 months ago

Hi @cupakob. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
embik commented 2 months ago

Hi @cupakob, thank you for the pull request! Before we can accept your contribution, please make sure it is signed off (the -s flag on git commit) so you signal that you are accepting the DCO. In addition, it would be great if you could write a short summary (how are the things you've changed smells?) so that this PR has the necessary context.

cupakob commented 2 months ago

how are the things you've changed smells?

done

kcp-ci-bot commented 1 month ago

LGTM label has been added.

Git tree hash: e6f28fcc02074193ec776c7bea2ed9774a7eb4c0

kcp-ci-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kcp-dev/kcp/blob/main/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
embik commented 1 month ago

/hold

embik commented 1 month ago

/ok-to-test

embik commented 1 month ago

/hold cancel

cupakob commented 1 month ago

/retest

embik commented 1 month ago

/retest