search

kcp-dev / kcp

Kubernetes-like control planes for form-factors and use-cases beyond Kubernetes and container workloads.
https://kcp.io
Apache License 2.0
2.29k stars 368 forks source link

e2e: virtual workspace log spew #805

Closed marun closed 1 week ago

marun commented 2 years ago

A virtual workspace e2e test failure revealed a considerable amount of log spew due to an apparent version mismatch between the server and plugin. In the event of version skew, maybe log output could be reduced?

Also, given that this was a ci job with fresh builds, shouldn't the plugin and server be using matching versions?

W0330 17:46:29.050840   28499 warnings.go:70] You are using an old kubectl-kcp plugin. Please update to a version matching the kcp server version "v0.0.0-master+$Format:%H$".
W0330 17:46:29.105702   28499 warnings.go:70] You are using an old kubectl-kcp plugin. Please update to a version matching the kcp server version "v0.0.0-f0ccd40+kcp".

cc: @sttts @davidfestal

sttts commented 2 years ago

This was intentional to notify all old plugin users. It is just too aggressive and super ugly in CI (because we don't set proper version info).

kcp-ci-bot commented 1 month ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kcp-ci-bot commented 2 weeks ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten