search

kcuilla / reactablefmtr

Streamlined Table Styling and Formatting for Reactable
https://kcuilla.github.io/reactablefmtr/
Other
206 stars 27 forks source link

save_reactable() / save_reactable_test() #28

Open johnmackintosh opened 2 years ago

johnmackintosh commented 2 years ago

Hi Thanks @kcuilla for this fantastic package!

Just browsing the new version and saw the ability to save the tables with save_reactable. In most places, the documentation refers to save_reactable, but when I went to call the function, it is currently named save_reactable_test()

kcuilla commented 2 years ago

Hi John, great catch! This was a careless naming error on my part that somehow didn't get caught during the package checks.

I just changed it back to save_reactable() in the dev version. Both save_reactable() and save_reactable_test() are exactly the same, just different names, so you can either download the dev version and use save_reactable() or continue using the CRAN version with save_reactable_test() (not recommended if you are putting it into a reproducible script or into production).

Thanks again for bringing this to my attention, I will need to release a new version to CRAN soon that fixes this issue.

asadow commented 1 year ago

I also got confused by the missing save_reactable().

dcomputing commented 1 year ago

Hi,

I'm have issues with save_reactable_test(). Under R4.3.1 it errors out with:

Warning: Error in &&: 'length = 8' in coercion to 'logical(1)'

asadow commented 1 year ago

Hi,

I'm have issues with save_reactable_test(). Under R4.3.1 it errors out with:

Warning: Error in &&: 'length = 8' in coercion to 'logical(1)'

For this you will want to create a reprex and open a new issue if necessary.