search

kcuzner / avrdude

avrdude with a Linux SPI programmer type
http://kevincuzner.com/2013/05/27/raspberry-pi-as-an-avr-programmer/
107 stars 68 forks source link

AVRDude: Redefine HAVE_LINUX_GPIO #15

Closed smvoss closed 7 years ago

smvoss commented 7 years ago

Fix a misnamed defined variable, "HAVE_LINUX_GPIO", as it should be "HAVE_LINUXGPIO" (as it is in the rest of the source).

Signed-off-by: Sam Voss samuel.voss@rockwellcollins.com

kcuzner commented 7 years ago

This modifies a file located in the mainline avrdude, unrelated to the linuxspi programmer type. Looking at the latest changes in the official SVN repository, the pindefs.h file doesn't appear to exist anymore. If you are patching this for your own usage, I suggest using the mainline avrdude version and compiling with linuxgpio enabled. This repository is meant just for changes related to linuxspi.

I don't actively pull in changes from the latest avrdude unless people request it, as changes are somewhat likely to be breaking for this programmer type and would require me to have a test setup. I submitted a patch back to the mainline repository about 4 years ago for the linuxspi programmer type, but they never responded (probably since I'm an outsider to that project).

smvoss commented 7 years ago

We have been pulling this patch forward for use in buildroot (they use your fork) in our buildsystem and for your spi to work on a lot of linux chips (which have more than 32 gpio pins) this patch is required as the flag won't be correctly set otherwise.

This patch makes your fork work out of the box, and allows anyone using buildroot (like us) to not have to maintain a patch specifically for larger linux micros.

I have sent an email out to the avrdude community asking about integrating this functionality because a lot of systems are using your fork, and it would be nice to reintegrate but I've yet to hear anything either.

Thanks for the spi integration by the way, very helpful!

kcuzner commented 7 years ago

I've merged your change, but I'm a little wary of diverging this fork in this manner from the mainline avrdude. Your reasoning made sense, though, so I hope this makes things easier for buildroot. I may look into merging back in the mainline avrdude to bring this repository up to date to avoid issues like this, but I would need to do so carefully.