search

kd1729 / portfolio

My Portfolio
https://kd1729.github.io/portfolio/
15 stars 32 forks source link

Improve the hovering effect of nav items #93

Closed sai-kumar0 closed 8 months ago

sai-kumar0 commented 8 months ago

What does this PR do ?

This PR improves the hovering effect of the navigation elements.

Fixes #92

Here is the link of the improved version. I hope you review it and feel free to text the issues.

https://sai-kumar0.github.io/portfolio/

image

kd1729 commented 8 months ago

What does this PR do ?

This PR improves the hovering effect of the navigation elements.

Fixes #92

Here is the link of the improved version. I hope you review it and feel free to text the issues.

https://sai-kumar0.github.io/portfolio/

image

Thanks, The underline effect is great, can you please try to center the text on the underline instead of left aligned

sai-kumar0 commented 8 months ago

hey @kd1729

I have tried to center the text on the underline instead of left aligned. But it is showing effect on responsive design i.e small screens instead of desktop screens. I have to change all the properties of navbar and recreate a navbar to center align the text on the underline. So it will change the structure. I hope you understand it.