search

kd8bny / cumulus

Quickly check the weather with this stylish web app
https://kd8bny.github.io/cumulus/
GNU General Public License v3.0
58 stars 10 forks source link

Pull request #3

Closed vadrian89 closed 8 years ago

vadrian89 commented 8 years ago

I have added the openweathermap api, changed info in the credit page and some small refactoring code changing, but there is an issue which makes it unfit for broad audience.
The select isn't showing the correctly, I have looked a bit on the internet and you might need to add some python code to be properly shown....I will mail you a screenshot with the issue to be more visible.

archisman-panigrahi commented 8 years ago

@vadrian89 Could you please upload a screenshot? You may not be able to select it as .apiselect it has not been added to disabledrag list in script.js line no 55

archisman-panigrahi commented 8 years ago

There is a bug in this pull. Weather is reloaded as soon as Source is selected.

vadrian89 commented 8 years ago

Ok, thank you, I will upload as soon as I am able.

vadrian89 commented 8 years ago

About the bug, it is intended that way, just I didn't thought about all situations :D, I will change the behaviour in next commit / pull. Thanks for all the feedback.

Edit: "it is intended that way", I thought that it should update the data right after the api change, didn't thought the user might want to change other info :D

vadrian89 commented 8 years ago

Daryl, do not merge this request until we fix the select issue. Thanks.

vadrian89 commented 8 years ago

Now the api can be selected, but I cannot target the background of the select. Should I change the color of the font to black and leave it so for now?

vadrian89 commented 8 years ago

Screenshot side be side: browser / application

vadrian89 commented 8 years ago

Implemented fixes.
Api selection

kd8bny commented 8 years ago

Are we good to merge this pull request now?

vadrian89 commented 8 years ago

Panigrahi, is it ok with you for merging?
By me is ok.