search

kd8bny / cumulus

Quickly check the weather with this stylish web app
https://kd8bny.github.io/cumulus/
GNU General Public License v3.0
58 stars 10 forks source link

Sometimes, size of cumulus is greater than 300 x 500 #5

Closed archisman-panigrahi closed 8 years ago

archisman-panigrahi commented 8 years ago

screenshot from 2016-09-30 10 35 49

The bug occurs as "Scattered Thunderstorms" occupies two lines. The weather condition has to be forced to stay in one line. Otherwise, it can be moved to the centre so that it does not take more than one line.

vadrian89 commented 8 years ago

I will make some test and check how it shows on the middle and come back.

vadrian89 commented 8 years ago

I made a change which goes like this, if the length of the description length is longer than 15 then show the description 1 row bellow and align to middle. I will give it a test run when I get home, as I can only test it in browser at work, this evening and if it goes well I will commit it :)

vadrian89 commented 8 years ago

Archisman I have made a pull request on Daryl's master branch, can you have a look and let me know if you approve so I can merge?

If everything is ok and you can merge, please do it and remake the ppa build if you want :), if no let me know what I fucked up :P.

archisman-panigrahi commented 8 years ago

The problem is that, I cannot find a place where "Scattered Thunderstorm" is occurring. I am going to accept the pull request for now, and will close this issue when I see the bug is fixed

vadrian89 commented 8 years ago

captura de ecran din 2016-10-01 22-14-19

Above is a sample how it would look, manually set description, if a long description would occur