search

kdabir / json-sql-console

Query json like a pro
https://json-sql-console.netlify.app
7 stars 3 forks source link

Add error handling for SQL syntax error #3

Closed odininon closed 7 years ago

odininon commented 7 years ago

Handles #2.

Hopefully, this is somewhat in the direction you are looking for.

kdabir commented 7 years ago

Wow this was pretty quick. Thank you so much for contributing.

A small observation: as I keep the console open to see the output, the error text div is hidden and I don't get feedback that query failed.

image

Once I scroll, then I see image

I think this will be automatically solved when #1 is implemented, till then we can notify in console as well about the failure.

odininon commented 7 years ago

Will attempt #1 when I get home from work, if it’s still open. I will also add the useful information into the console as well.

odininon commented 7 years ago

Just saw someone else wanted to work on it. I’ll just add the information back to the console for errors :)

kdabir commented 7 years ago

No worries, eventually I would want to get rid of the console based output and have all data shown and updated in the UI. The results grid is going to be one of the challenging part. You may also collaborate the with other person to review the PR. Thanks again for the interest and extending help.

odininon commented 7 years ago

Not a problem :) Gives me a chance to practice my react without having to think of my own projects.