Validate input json - Githubissues

kdabir / json-sql-console

Query json like a pro

https://json-sql-console.netlify.app

7 stars 3 forks source link

Validate input json #4

Closed kdabir closed 6 years ago

kdabir commented 6 years ago

There are few validations that we can do on the json data for optimal user experience while running queries:

[x] It should be a parsable JSON array
[x] restrict number of items to 1000 (since its all sync, we don't want to freeze browser)
[x] have some upper cap on size in kb (need to figure out what size)?

odininon commented 6 years ago

This brings up a good point for #1. Do we want to show all 1000 rows at once, or implement a paging solution?

Could even be a infinity scroll list, but sending them in chunks should help the render cycles.

kdabir commented 6 years ago

I was thinking about it for a while, as a perf optimization we can think about:

loading data in chunks in view
running sql engine in webworker instead of main loop.

If 1 is not too hard to do, we should go ahead with that, otherwise we are putting a soft limit of 1000 records anyways for now, that should help us get over the browser freeze pretty quickly. Some hacks with setTimeout can also take us some far before we have to "really" solve the proble.