search

kdahlquist / GRNmap

Gene Regulatory Network modeling and parameter estimation
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Test suite is failing silently; if individual test fails, then suite needs to fail #397

Closed kdahlquist closed 6 years ago

kdahlquist commented 6 years ago

@jtorre39 found that when the test suite is run, it only reports at the end if the tests completed, not if they passed or failed, so tests are failing "silently" if you don't scroll up to look at the results. The test suite has to report that it failed if an individual test failed to alert the developer.

im-deepfriedwater commented 6 years ago

Added a check at the end of the test suite to check if any tests failed. A msgbox is now displayed in a new window regarding whether any test failed, or if they all passed. I believe it is sufficiently failing "loudly" as of now.

bengfitzpatrick commented 6 years ago

notes on this in "Addressing Issues" comment above. Tests all passing. closing