search

kdash-rs / kdash

A simple and fast dashboard for Kubernetes
https://kdash.cli.rs
MIT License
2.06k stars 78 forks source link

Enter wrong pod when using "global filtering by resource name" #445

Open clayms opened 6 months ago

clayms commented 6 months ago

Describe the bug When I filter pods by pressing f "global filtering by resource name", when I highlight the pod I want to enter with the arrow keys, then press enter to enter the pod, I enter a completely different pod. It appears that the index from the list of unfiltered pods list is still getting used to select which pod to enter.

To Reproduce Steps to reproduce the behavior or a screencast

  1. on pod resource pane
  2. apply global filter
  3. highlight pod and note name
  4. Enter
  5. Note pod entered is not the same

Expected behavior Enter the correct pod

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

clayms commented 6 months ago

I can confirm that the pod that was highlighted before applying the filter is the pod that is entered after applying the filter. If I use the arrow keys to move the selection highlight one pod down, and enter that pod, I still don't enter into the selected pod shown, but instead enter into the second pod from the un-filtered list of pods.

Therefore, the index or list used to enter into a pod is not getting updated after filtering the list of pods.

deepu105 commented 5 months ago

Good catch. I'll look into it when I'm free. Thanks for reporting it

Thanks & Regards, Deepu

On Fri, Mar 8, 2024 at 4:43 PM clayms @.***> wrote:

I can confirm that the pod that was highlighted before applying the filter is the pod that is entered after applying the filter. If I use the arrow keys to move the selection highlight one pod down, and enter that pod, I still don't enter into the selected pod shown, but instead enter into the second pod from the un-filtered list of pods.

Therefore, the index or list used to enter into a pod is not getting updated after filtering the list of pods.

— Reply to this email directly, view it on GitHub https://github.com/kdash-rs/kdash/issues/445#issuecomment-1985920681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF3QB32CLP2QOE3DVGLYXHMA5AVCNFSM6AAAAABEMZ6YMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVHEZDANRYGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>