search

kdave / btrfs-progs

Development of userspace BTRFS tools
GNU General Public License v2.0
527 stars 239 forks source link

kernel-shared/uapi/btrfs.h: fix BTRFS_IOC_SCAN_DEV #706

Closed trofi closed 8 months ago

trofi commented 8 months ago

Without the change BTRFS_IOC_SCAN_DEV aliased with BTRFS_IOC_FORGET_DEV. It's a regression introduced in fcd9142b6 "btrfs-progs: docs: formatting, fixups, updates".

It manifests as a sudden device disappearance when device is scanned:

machine # [    4.095032] Btrfs loaded, crc32c=crc32c-intel, zoned=no, fsverity=no
machine # ERROR: device scan failed on '/dev/vdb': No such file or directory
machine # ERROR: device scan failed on '/dev/vdc': No such file or directory
(finished: must succeed: mkfs.btrfs -d raid0 /dev/vdb /dev/vdc, in 10.31 seconds)

Reported-by: Atemu atemu.main@gmail.com Bug: https://github.com/NixOS/nixpkgs/issues/265668

kdave commented 8 months ago

It's a regression introduced in fcd9142 "btrfs-progs: docs: formatting, fixups, updates".

Oh crap, that was an accidental edit in uapi/btrfs.h, thanks for the fix, I'll do a quick bugfix release.

kdave commented 8 months ago

Merged and released as v6.6.1, thanks again.