kdave / btrfs-progs

Development of userspace BTRFS tools
GNU General Public License v2.0
527 stars 239 forks source link

6.6.3: wrong return code for when trying to create a duplicate subvolume #730

Closed vojtechtrefny closed 5 months ago

vojtechtrefny commented 5 months ago

When trying to create a new subvolume which already exists, btrfs subvolume create has return code 0 with 6.6.3:

# btrfs subvolume create /mnt/test/a
Create subvolume '/mnt/test/a'
# btrfs subvolume create /mnt/test/a
ERROR: target path already exists: /mnt/test/a
# echo $?
0
# btrfs --version
btrfs-progs v6.6.3

Works as expected with 6.6.2:

# btrfs subvolume create /mnt/test/a
ERROR: target path already exists: /mnt/test/a
# echo $?
1
# btrfs --version
btrfs-progs v6.6.2
mbiebl commented 5 months ago

I can confirm that the referenced commit fixes the libblockdev test suite failure.

kdave commented 5 months ago

Thanks, will be released in 6.7.