search

kdave / btrfs-progs

Development of userspace BTRFS tools
GNU General Public License v2.0
527 stars 239 forks source link

Disable faulty check for a running dev-replace while `btrfstune --csum`ing #800

Closed aidan-gibson closed 4 weeks ago

aidan-gibson commented 1 month ago

This code I'm commenting out doesn't check for a running dev-replace, as intended. It checks if a dev-replace has ever been done. I'm unsure if the intention of BTRFS_DEV_REPLACE_KEY was to monitor currently a currently running dev-replace and wasn't implemented properly, or it was intended to keep a history of dev-replaces and is functioning properly, but as this code is currently written, you cannot btrfstune --csum if a dev-replace has ever been done.

Tested on Arch and Debian to be sure.

Fixes #798

adam900710 commented 4 weeks ago

Sorry, this is not a proper fix, it just completely ignore all dev-replace checks which is totally wrong.

Zygo's correct, we should do more checks instead. Closing and would submit a proper fix instead.

Thanks for the report.