kdave / btrfsmaintenance

Scripts for btrfs maintenance tasks like periodic scrub, balance, trim or defrag on selected mountpoints or directories.
GNU General Public License v2.0
900 stars 79 forks source link

Add support for .timer units #29

Closed kdave closed 6 years ago

kdave commented 7 years ago

Currently, the scripts are started by the cron daemon. There's some user interst to use the systemd .timer units.

The scripts are independent of the executing daemon. What's needed:

sten0 commented 7 years ago

Yay! I've been planning to officially package btrfsmaintenance for Debian for a while, and this is something I'm very much interested in, and would like to help out with in late May or June. I would also like to see:

  1. Because Debian supports both sysvinit and systemd I'm going to also have to ask for some help on how it should be packaged. My best guess is that there will be a btrfsmaintenance virtual package satisfied by either btrfsmaintenance-sysvinit or btrfsmaintenance-systemd.

  2. Another of my concerns is the different syntaxes I've seen in how different distributions write their systemd timer units. At this point I'm unable to say whether these differences are a matter of style/convention or actually affect functionality, but I'm willing to support the Debian expectations. Worse case scenario would be maintaining a patch branch and rebasing off official upstream btrfsmaintenance and manually resolving the conflicts.

madmartin commented 7 years ago

Hi, I added btrfsmaintenance to gentoo and had a PR for systemd timers. Maybe someone wants to get in contact with the author for a well designed implementation here. The PR with my comments is here: https://github.com/gentoo/gentoo/pull/5160

comio commented 7 years ago

Dear all,

I issued a PR #34 in order to add systemd timers support. Any comment is welcome.

ciao

luigi

comio commented 7 years ago

See PR #35 with the updated patches.

ciao

luigi

kdave commented 6 years ago

The pull request #36 implements the core part of the timers.

kdave commented 6 years ago

The points from discussion moved to a separate issue, the timers are considered done and will be in the next release.